Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add milestoning setup in Query Option #3148

Merged
merged 2 commits into from
May 20, 2024

Conversation

irisyngao
Copy link
Contributor

@irisyngao irisyngao commented May 14, 2024

Summary

Add milestoning setup in Query Option

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)
Screen.Recording.2024-05-14.at.6.11.00.PM.mov
Screen.Recording.2024-05-14.at.6.22.42.PM.mov
Screenshot 2024-05-14 at 2 57 47 PM Screenshot 2024-05-14 at 6 10 00 PM Screenshot 2024-05-14 at 2 57 42 PM Screenshot 2024-05-14 at 3 29 38 PM Screenshot 2024-05-14 at 2 57 55 PM Screenshot 2024-05-14 at 2 58 45 PM Screenshot 2024-05-14 at 4 50 45 PM

@irisyngao irisyngao requested a review from a team as a code owner May 14, 2024 17:52
Copy link

changeset-bot bot commented May 14, 2024

🦋 Changeset detected

Latest commit: a6c947c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@finos/legend-query-builder Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-query Patch
@finos/legend-application-studio Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-manual-tests Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@irisyngao irisyngao marked this pull request as draft May 14, 2024 17:54
@irisyngao irisyngao self-assigned this May 14, 2024
@irisyngao irisyngao marked this pull request as ready for review May 14, 2024 19:00
@irisyngao irisyngao force-pushed the milestone branch 5 times, most recently from 9cf5c80 to fbf7f08 Compare May 14, 2024 20:55
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 82.86853% with 43 lines in your changes are missing coverage. Please review.

Project coverage is 47.86%. Comparing base (1ce2ea7) to head (a6c947c).
Report is 77 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3148      +/-   ##
==========================================
- Coverage   48.20%   47.86%   -0.34%     
==========================================
  Files        2007     1975      -32     
  Lines      338437   334887    -3550     
  Branches    13019    12766     -253     
==========================================
- Hits       163139   160291    -2848     
+ Misses     174989   174304     -685     
+ Partials      309      292      -17     
Files Coverage Δ
...ponents/explorer/QueryBuilderMilestoningEditor.tsx 93.38% <100.00%> (+4.37%) ⬆️
...etch-structure/QueryBuilderResultModifierPanel.tsx 92.62% <100.00%> (-6.27%) ⬇️
...stores/fetch-structure/tds/QueryBuilderTDSState.ts 78.48% <100.00%> (+2.57%) ⬆️
...stores/milestoning/QueryBuilderMilestoningState.ts 88.74% <100.00%> (+3.52%) ⬆️
...omponents/fetch-structure/QueryBuilderTDSPanel.tsx 71.69% <62.93%> (-1.79%) ⬇️

... and 140 files with indirect coverage changes

@irisyngao
Copy link
Contributor Author

Add logic to handle cancel and apply

@irisyngao irisyngao marked this pull request as draft May 16, 2024 19:20
@irisyngao irisyngao force-pushed the milestone branch 2 times, most recently from fd40f88 to 72d3280 Compare May 16, 2024 21:43
@irisyngao irisyngao marked this pull request as ready for review May 16, 2024 21:43
@MauricioUyaguari MauricioUyaguari merged commit 8e2efa7 into finos:master May 20, 2024
13 checks passed
irisyngao pushed a commit to irisyngao/legend-studio that referenced this pull request Jun 5, 2024
irisyngao pushed a commit to irisyngao/legend-studio that referenced this pull request Jun 5, 2024
irisyngao pushed a commit to irisyngao/legend-studio that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants