Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve sql playground and fix problems with monaco-editor not showing suggestions #2278

Merged
merged 6 commits into from
May 30, 2023

Conversation

akphi
Copy link
Contributor

@akphi akphi commented May 30, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented May 30, 2023

🦋 Changeset detected

Latest commit: 04c9288

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@finos/legend-application-studio Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-taxonomy Patch
@finos/legend-query-builder Patch
@finos/legend-dev-utils Patch
@finos/stylelint-config-legend-studio Patch
@finos/eslint-plugin-legend-studio Patch
@finos/babel-preset-legend-studio Patch
@finos/legend-lego Patch
@finos/legend-art Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-mastery Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-taxonomy-bootstrap Patch
@finos/legend-application-query Patch
@finos/legend-manual-tests Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-taxonomy-deployment Patch
@finos/legend-application Patch
@finos/legend-extension-tracer-zipkin Patch
@finos/legend-graph Patch
@finos/legend-server-depot Patch
@finos/legend-server-sdlc Patch
@finos/legend-storage Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #2278 (04c9288) into master (1d1aafd) will increase coverage by 0.01%.
The diff coverage is 15.38%.

@@            Coverage Diff             @@
##           master    #2278      +/-   ##
==========================================
+ Coverage   39.40%   39.42%   +0.01%     
==========================================
  Files        1560     1561       +1     
  Lines       73125    73102      -23     
  Branches    17027    17030       +3     
==========================================
+ Hits        28818    28822       +4     
+ Misses      44194    44167      -27     
  Partials      113      113              
Impacted Files Coverage Δ
...pplication-studio/src/components/editor/Editor.tsx 71.42% <ø> (ø)
...r-group/diff-editor/EntityChangeConflictEditor.tsx 15.20% <0.00%> (ø)
...studio/src/components/editor/side-bar/Explorer.tsx 72.85% <0.00%> (ø)
...ation-taxonomy/src/components/TaxonomyExplorer.tsx 9.18% <0.00%> (+0.18%) ⬆️
...ation-taxonomy/src/stores/TaxonomyExplorerStore.ts 12.66% <0.00%> (ø)
...ackages/legend-lego/src/code-editor/CodeEditor.tsx 22.22% <0.00%> (-0.51%) ⬇️
...ure/tds/post-filter/QueryBuilderPostFilterState.ts 43.69% <ø> (+0.40%) ⬆️
...ilder/src/stores/filter/QueryBuilderFilterState.ts 45.04% <ø> (+0.49%) ⬆️
...ide/src/components/editor-group/PureFileEditor.tsx 12.76% <8.57%> (+0.46%) ⬆️
...ide/src/components/panel-group/TestRunnerPanel.tsx 8.29% <9.52%> (+0.42%) ⬆️
... and 9 more

@akphi akphi marked this pull request as ready for review May 30, 2023 04:55
@akphi akphi requested a review from a team as a code owner May 30, 2023 04:55
@akphi akphi merged commit 2c19cb4 into finos:master May 30, 2023
@akphi akphi deleted the emma branch May 30, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant