Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support calendar aggregations for derivation columns #2253

Merged
merged 1 commit into from
May 23, 2023

Conversation

gayathrir11
Copy link
Contributor

@gayathrir11 gayathrir11 commented May 22, 2023

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)
calendar.mp4

@gayathrir11 gayathrir11 requested a review from a team as a code owner May 22, 2023 10:55
@changeset-bot
Copy link

changeset-bot bot commented May 22, 2023

🦋 Changeset detected

Latest commit: f19c1e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@finos/legend-query-builder Patch
@finos/legend-application-query Patch
@finos/legend-application-studio Patch
@finos/legend-application-taxonomy-bootstrap Patch
@finos/legend-application-taxonomy Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-manual-tests Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-mastery Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-snowflake-app Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-application-taxonomy-deployment Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-pure-ide-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #2253 (9a07610) into master (aaa8b35) will increase coverage by 0.16%.
The diff coverage is 96.72%.

❗ Current head 9a07610 differs from pull request most recent head f19c1e5. Consider uploading reports for the commit f19c1e5 to get more accurate results

@@            Coverage Diff             @@
##           master    #2253      +/-   ##
==========================================
+ Coverage   39.41%   39.58%   +0.16%     
==========================================
  Files        1556     1556              
  Lines       72476    72507      +31     
  Branches    16881    16890       +9     
==========================================
+ Hits        28570    28702     +132     
+ Misses      43793    43692     -101     
  Partials      113      113              
Impacted Files Coverage Δ
...regateCalendarFunctionValueSpecificationBuilder.ts 94.28% <ø> (+24.84%) ⬆️
...ueryBuilderAggregateCalendarFunction_Annualized.ts 71.42% <ø> (+7.14%) ⬆️
...tions/QueryBuilderAggregateCalendarFunction_Cme.ts 100.00% <ø> (+35.71%) ⬆️
...ctions/QueryBuilderAggregateCalendarFunction_Cw.ts 71.42% <ø> (+7.14%) ⬆️
...ons/QueryBuilderAggregateCalendarFunction_Cw_Fm.ts 71.42% <ø> (+7.14%) ⬆️
...QueryBuilderAggregateCalendarFunction_Cy_Minus2.ts 71.42% <ø> (+7.14%) ⬆️
...QueryBuilderAggregateCalendarFunction_Cy_Minus3.ts 71.42% <ø> (+7.14%) ⬆️
...tions/QueryBuilderAggregateCalendarFunction_Mtd.ts 71.42% <ø> (+7.14%) ⬆️
...ons/QueryBuilderAggregateCalendarFunction_P12Wa.ts 71.42% <ø> (+7.14%) ⬆️
...ns/QueryBuilderAggregateCalendarFunction_P12Wtd.ts 71.42% <ø> (+7.14%) ⬆️
... and 26 more

... and 16 files with indirect coverage changes

@gayathrir11 gayathrir11 self-assigned this May 23, 2023
@gayathrir11 gayathrir11 added the Component: Query Builder Issues related to query builder core label May 23, 2023
@gayathrir11 gayathrir11 added this to the 10.0.0 milestone May 23, 2023
@akphi akphi merged commit 250117a into finos:master May 23, 2023
@gayathrir11 gayathrir11 deleted the calendar_bug branch October 11, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Builder Issues related to query builder core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants