-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support test data generation for services with parameters #2237
Conversation
🦋 Changeset detectedLatest commit: 0d90da5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #2237 +/- ##
==========================================
+ Coverage 39.36% 39.61% +0.25%
==========================================
Files 1551 1556 +5
Lines 72334 72468 +134
Branches 16841 16878 +37
==========================================
+ Hits 28473 28710 +237
+ Misses 43748 43645 -103
Partials 113 113
|
|
619f024
to
9f74ea1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small comment
...src/stores/editor/editor-state/element-editor-state/service/testable/ServiceTestDataState.ts
Show resolved
Hide resolved
const connection = guaranteeNonNullable( | ||
this.resolveConnectionValue(this.connectionData.connectionId), | ||
`Unable to resolve connection ID '${this.connectionData.connectionId}`, | ||
// NOTE: since we don't have a generic mechanism for test-data generation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this api call takes a bit of time. we should be adding generatingTestDataSate
to keep track of that and show loading indicator
Summary
Support test data generation for services with parameters
How did you test this change?