Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension mechanism for Testable #1547

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

gayathrir11
Copy link
Contributor

@gayathrir11 gayathrir11 commented Oct 11, 2022

Summary

  • Add extension mechanism for Testable
  • Modify code in dsl-persistence to make use of this extension mechanism

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2022

🦋 Changeset detected

Latest commit: 0dbfb55

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@finos/legend-graph Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-query Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-application-studio Patch
@finos/legend-application-taxonomy-bootstrap Patch
@finos/legend-application-taxonomy Patch
@finos/legend-application Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-mastery Patch
@finos/legend-extension-dsl-persistence-cloud Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-format-json-schema Patch
@finos/legend-extension-format-morphir Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-manual-tests Patch
@finos/legend-query-builder Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-taxonomy-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@finos-cla-bot finos-cla-bot bot added the cla-present CLA Signed label Oct 11, 2022
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #1547 (0dbfb55) into master (04e914b) will decrease coverage by 0.02%.
The diff coverage is 34.61%.

@@            Coverage Diff             @@
##           master    #1547      +/-   ##
==========================================
- Coverage   40.67%   40.65%   -0.03%     
==========================================
  Files        1268     1268              
  Lines       56397    56425      +28     
  Branches    12734    12746      +12     
==========================================
  Hits        22941    22941              
- Misses      33373    33401      +28     
  Partials       83       83              
Impacted Files Coverage Δ
...hManager/DSL_Persistence_PureGraphManagerPlugin.ts 32.25% <0.00%> (ø)
...d-graph/src/graphManager/PureGraphManagerPlugin.ts 0.00% <ø> (ø)
.../action/changeDetection/Testable_ObserverHelper.ts 16.66% <0.00%> (-3.34%) ⬇️
...raphManager/helpers/DSL_Data_GraphManagerHelper.ts 38.88% <0.00%> (-17.37%) ⬇️
...nager/protocol/pure/PureProtocolProcessorPlugin.ts 0.00% <ø> (ø)
...ransformation/pureGraph/from/V1_TestTransformer.ts 53.65% <0.00%> (-3.85%) ⬇️
...ation/pureGraph/to/helpers/V1_TestBuilderHelper.ts 50.00% <0.00%> (-3.20%) ⬇️
...pureGraph/to/helpers/V1_TestResultBuilderHelper.ts 22.77% <0.00%> (-3.76%) ⬇️
...serializationHelpers/V1_TestSerializationHelper.ts 44.33% <13.33%> (-4.05%) ⬇️
...ure/DSL_Persistence_PureProtocolProcessorPlugin.ts 77.08% <80.00%> (+0.56%) ⬆️
... and 2 more

@gayathrir11 gayathrir11 self-assigned this Oct 11, 2022
@gayathrir11 gayathrir11 added this to the 8.0.0 milestone Oct 11, 2022
@MauricioUyaguari MauricioUyaguari merged commit 971a3cf into finos:master Oct 11, 2022
@gayathrir11 gayathrir11 deleted the testable_ext branch March 3, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants