Support duplicated property mapping for property type other than class #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 29272c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1dad91b to
5e8fc00
Compare
Codecov Report
@@ Coverage Diff @@
## master #1504 +/- ##
==========================================
- Coverage 40.58% 40.57% -0.02%
==========================================
Files 1264 1264
Lines 56277 56294 +17
Branches 12708 12718 +10
==========================================
+ Hits 22842 22843 +1
- Misses 33353 33369 +16
Partials 82 82
|
f1acaa5 to
a0e31a5
Compare
xannem
reviewed
Sep 28, 2022
...gend-application-studio/style/components/editor/mapping-editor/_property-mapping-editor.scss
Outdated
Show resolved
Hide resolved
akphi
requested changes
Sep 30, 2022
packages/legend-application-studio/src/stores/graphModifier/DSLMapping_GraphModifierHelper.ts
Outdated
Show resolved
Hide resolved
...gend-application-studio/style/components/editor/mapping-editor/_property-mapping-editor.scss
Outdated
Show resolved
Hide resolved
...pplication-studio/src/components/editor/edit-panel/mapping-editor/PropertyMappingsEditor.tsx
Outdated
Show resolved
Hide resolved
...pplication-studio/src/components/editor/edit-panel/mapping-editor/PropertyMappingsEditor.tsx
Show resolved
Hide resolved
...pplication-studio/src/components/editor/edit-panel/mapping-editor/PropertyMappingsEditor.tsx
Outdated
Show resolved
Hide resolved
0208c12 to
8e125dd
Compare
akphi
requested changes
Oct 6, 2022
packages/legend-application-studio/src/stores/graphModifier/DSL_Mapping_GraphModifierHelper.ts
Outdated
Show resolved
Hide resolved
...pplication-studio/src/components/editor/edit-panel/mapping-editor/PropertyMappingsEditor.tsx
Outdated
Show resolved
Hide resolved
...pplication-studio/src/components/editor/edit-panel/mapping-editor/PropertyMappingsEditor.tsx
Outdated
Show resolved
Hide resolved
...pplication-studio/src/components/editor/edit-panel/mapping-editor/PropertyMappingsEditor.tsx
Outdated
Show resolved
Hide resolved
...pplication-studio/src/components/editor/edit-panel/mapping-editor/PropertyMappingsEditor.tsx
Outdated
Show resolved
Hide resolved
...ation-studio/src/stores/editor-state/element-editor-state/mapping/MappingElementDecorator.ts
Outdated
Show resolved
Hide resolved
...ation-studio/src/stores/editor-state/element-editor-state/mapping/MappingElementDecorator.ts
Outdated
Show resolved
Hide resolved
8e125dd to
2d5a14f
Compare
added 2 commits
October 7, 2022 14:38
akphi
approved these changes
Oct 8, 2022
packages/legend-application-studio/src/stores/graphModifier/DSL_Mapping_GraphModifierHelper.ts
Show resolved
Hide resolved
...ation-studio/src/stores/editor-state/element-editor-state/mapping/MappingElementDecorator.ts
Show resolved
Hide resolved
...ation-studio/src/stores/editor-state/element-editor-state/mapping/MappingElementDecorator.ts
Show resolved
Hide resolved
...ation-studio/src/stores/editor-state/element-editor-state/mapping/MappingElementDecorator.ts
Show resolved
Hide resolved
...pplication-studio/src/components/editor/edit-panel/mapping-editor/PropertyMappingsEditor.tsx
Show resolved
Hide resolved
| @@ -96,6 +112,29 @@ | |||
| color: var(--color-light-grey-100); | |||
| } | |||
|
|
|||
| &__entries { | |||
| &__entry { | |||
There was a problem hiding this comment.
move this style out. Also, use @include flexVCenter here
| setImplementationHasParserError | ||
| } | ||
| /> | ||
| {propertyMappingStates.length > 1 && |
There was a problem hiding this comment.
Could propbably create a component to wrap thi and make this less duplicated I think. Something like:
<GenericPropertyMappingEditor><SomePropertyMappingEditor /></GenericPropertyMappingEditor>
akphi
added a commit
to akphi/legend-studio
that referenced
this pull request
Oct 9, 2022
akphi
added a commit
to akphi/legend-studio
that referenced
this pull request
Oct 11, 2022
11 tasks
akphi
added a commit
to akphi/legend-studio
that referenced
this pull request
Oct 11, 2022
akphi
added a commit
that referenced
this pull request
Oct 11, 2022
* remove @types/lossless-json * remove ReactMarkdownMocker.jsx * minor styling fix for custom date picker * minor cleanups * cleanups post #1521 * cleanups * rework ApplicationNavigator and support platform navigation blocking * support application backdrop * cleanup after #1504 * minor cleanups * rework application navigator to support blocking * minor cleanups post #1541 * minor cleanups post #1507 * move value-specification editor logic from @finos/legend-application to @finos/legend-query-builder * minor fixes * query builder: properly use modifier for modification of value specification tree * query builder: fix minor bug when building query value specification * value-spec: fix minor typings error in metamodels * bump dependencies * add changeset * improve documentations on ESM workarounds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1461
How did you test this change?
Screen.Recording.2022-09-27.at.5.50.30.PM.mov