Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add element path to element dropdown #1240

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Conversation

irisyngao
Copy link
Contributor

@irisyngao irisyngao commented Jun 27, 2022

Summary

Fixes #1081

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)
deno.mov

@changeset-bot
Copy link

changeset-bot bot commented Jun 27, 2022

🦋 Changeset detected

Latest commit: 34a6b7e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages
Name Type
@finos/legend-application Patch
@finos/legend-studio Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-external-language-morphir Patch
@finos/legend-extension-external-store-service Patch
@finos/legend-extension-mapping-generation Patch
@finos/legend-query-app Patch
@finos/legend-query Patch
@finos/legend-studio-app Patch
@finos/legend-studio-extension-management-toolkit Patch
@finos/legend-studio-extension-query-builder Patch
@finos/legend-taxonomy-app Patch
@finos/legend-taxonomy Patch
@finos/legend-graph-extension-collection Patch
@finos/legend-query-deployment Patch
@finos/legend-studio-deployment Patch
@finos/legend-taxonomy-deployment Patch
@finos/legend-manual-tests Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@finos-cla-bot finos-cla-bot bot added the cla-present CLA Signed label Jun 27, 2022
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #1240 (34a6b7e) into master (ed3da13) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1240      +/-   ##
==========================================
- Coverage   42.21%   42.20%   -0.01%     
==========================================
  Files        1133     1133              
  Lines       50534    50543       +9     
  Branches    11592    11597       +5     
==========================================
  Hits        21332    21332              
- Misses      29141    29150       +9     
  Partials       61       61              
Impacted Files Coverage Δ
...-application/src/application/LegendApplication.tsx 7.22% <0.00%> (-0.78%) ⬇️
...it-panel/mapping-editor/NewMappingElementModal.tsx 51.04% <ø> (ø)
...nents/editor/edit-panel/uml-editor/ClassEditor.tsx 54.14% <ø> (ø)
...mponents/editor/side-bar/CreateNewElementModal.tsx 49.13% <0.00%> (-0.29%) ⬇️

@MauricioUyaguari MauricioUyaguari merged commit 7b5dfbe into finos:master Jun 28, 2022
@akphi akphi deleted the dropdown branch June 28, 2022 02:20
@MauricioUyaguari
Copy link
Member

@YannanGao-gs could we make sure we do this for query builder dropdown as well. Could you check other places where we have packagable element dropdown as well.

akphi added a commit to akphi/legend-studio that referenced this pull request Jun 28, 2022
akphi added a commit to akphi/legend-studio that referenced this pull request Jun 28, 2022
MauricioUyaguari pushed a commit that referenced this pull request Jun 28, 2022
* update yarn.lock

* cleanup source information handler

* reorganize legend-application

* modularize plan-viewer

* diagram: support align and distribute

* bump dependencies

* rebase post #1240

* simplify contextual documentation config

* allow fetching documentation data from external source

* move documentation out to external source and add checker for required doc entries

* minor refactor post #1240

* minor fixes

* bump dependencies
jinanisha pushed a commit to jinanisha/legend-studio that referenced this pull request Aug 5, 2022
jinanisha pushed a commit to jinanisha/legend-studio that referenced this pull request Aug 5, 2022
* update yarn.lock

* cleanup source information handler

* reorganize legend-application

* modularize plan-viewer

* diagram: support align and distribute

* bump dependencies

* rebase post finos#1240

* simplify contextual documentation config

* allow fetching documentation data from external source

* move documentation out to external source and add checker for required doc entries

* minor refactor post finos#1240

* minor fixes

* bump dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Add element path to element dropdown
2 participants