generated from finos/software-project-blueprint
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify metamodels #1153
Merged
Merged
simplify metamodels #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bf902e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
27 tasks
Codecov Report
@@ Coverage Diff @@
## master #1153 +/- ##
==========================================
- Coverage 42.49% 42.47% -0.03%
==========================================
Files 1131 1133 +2
Lines 50017 50009 -8
Branches 11433 11432 -1
==========================================
- Hits 21257 21241 -16
- Misses 28689 28698 +9
+ Partials 71 70 -1
|
@akphi another minor fixes in the making :) |
MauricioUyaguari
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
mobx
usage in@finos/legend-graph
, practically from this moment, the core graph does not usemobx
at all; onlygraph manager
doesmetamodels
that we added to support better graph navigation (i.e.owner
,parent
, etc.) that are not in the actual metamodels, we should prefix them with,_
, e.g._OWNER
,_UUID
,_PARENT
. Also make these fieldsreadonly
buildState
out ofBasicModel
andDependencyManager
, pass it in as parameter, move them intoGraphManagerState
enum
out of model directoriesprotocols/pure/v1/model, metamodels
: these enums are not native to the metamodel, but was added originally forStudio
needsLocalMappingPropertyInfo.localMappingPropertyType
OptionalSetImplementationReference
How did you test this change?