Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: remove graph building in text mode to improve performance #966

Closed
1 of 7 tasks
Tracked by #927
MauricioUyaguari opened this issue Mar 21, 2022 · 1 comment · Fixed by #1693
Closed
1 of 7 tasks
Tracked by #927

Enhancement: remove graph building in text mode to improve performance #966

MauricioUyaguari opened this issue Mar 21, 2022 · 1 comment · Fixed by #1693
Assignees
Labels
Component: Graph Manager Issues related to graph processing and management (including interaction with engine server) logic Component: Text Mode Studio Core Team Opened by a member of the Studio core team Type: Enhancement Type: Feature Request Type: Refactor
Milestone

Comments

@MauricioUyaguari
Copy link
Member

MauricioUyaguari commented Mar 21, 2022

c### Similar requests

  • I have searched and found no existing similar requests

How are you using Studio?

Legend Studio

What problems are you trying to solve?

In order to improve performance in text mode, we could consider removing Studio graph building during text mode.

Describe the solution you would like to see implemented

Currently, we rebuild our graph during each compilation. We will move to rebuild only when leaving text mode.

  • remove logic of rebuilding when firing F9 in text-mode
  • handle explorer tree logic which requires graph: we can reason out the explorer tree from just the element paths
  • handle change detection (show that we disabled change detection in text mode and prevent users from saving, or we could use another change detection mode - maybe compare hashes index built from protocol models)
  • Move from a soft transition from/to text mode to a hard transition. Right now we try to keep the form mode state of studio in memory when going to text mode. we should delete that and only rebuild when going back to form mode - we currently already somewhat doing this, but we haven't pushed this hard enough, this would really help avoiding memory-leak: genericize EditorStore and implement TextEditorStore, FormEditorStore to further separate these out (See RFC: Rework editor modes #317 )
    • ? would remove the reprocessElementEditorState

Describe alternatives you have considered

No response

Documentation, Design, Adoption, Migration Strategy

No response

Contribution

  • I would like to work on this feature
@github-actions github-actions bot added the Studio Core Team Opened by a member of the Studio core team label Mar 21, 2022
@akphi akphi added this to the On Deck milestone Mar 21, 2022
@akphi akphi added Component: Graph Manager Issues related to graph processing and management (including interaction with engine server) logic Component: Text Mode labels Mar 21, 2022
@MauricioUyaguari MauricioUyaguari modified the milestones: On Deck, 5.0.0, 6.0.0 Mar 26, 2022
@beekemarie beekemarie modified the milestones: 6.0.0, On Deck May 3, 2022
@akphi akphi modified the milestones: On Deck, Backlog Nov 1, 2022
@akphi akphi changed the title Feature request: remove graph building in text mode Enhancement: remove graph building in text mode to improve performance Nov 1, 2022
@gayathrir11 gayathrir11 self-assigned this Nov 7, 2022
@gayathrir11 gayathrir11 modified the milestones: Backlog, 9.0.0 Nov 7, 2022
@gayathrir11
Copy link
Contributor

gayathrir11 commented Nov 9, 2022

  • Update the graph for testables
  • Make sure UI does not break when we click on the new elements added in the Local changes tab
  • Handle pushing of changes when you are in text mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Graph Manager Issues related to graph processing and management (including interaction with engine server) logic Component: Text Mode Studio Core Team Opened by a member of the Studio core team Type: Enhancement Type: Feature Request Type: Refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants