RFC: Rework editor modes

[akphi]

💬 Request for Comments

Within Studio, we currently support 3 modes: editor, viewer, and review, each is somewhat being treated differently: e.g. viewer mode does not allow editing elements, review mode does not allow viewing and working with the element, etc. When query builder becomes standalone, we might need to yet support another mode. What we realize is, these modes are not too far off from one another. In fact, we are trying to bring them closer in functionalities - see #297.

In fact, we should consider all the flows and just make them different in a very small set of features. Instead of thinking that we should create a brand new mode without any functionality and then adding them one by one (like what we're trying to do in #297), we probably should start using EditorStore and having ways to disable certain features if that's cleaner. i.e. starts from the full one - editor mode - and see what we can turn off

Implementation Plan

• Introduce EditorMode - studio: rework handling of multiple SDLC instances #642
• Start moving logic and creating new flags in EditorMode for places we need to use isInViewerMode etc. NOTE: we should also review the content of the old implementation plan.
• We should use this for ViewerStore as well as there are many ways to launch Viewer mode now

Implementation Plan (OLD - TO BE REVISED)

• Viewer mode:
  • Disable saving/Review/Workspace Updater
  • Keep the LocalChange panel around, but then have a feature so that people can make changes to the model and if they like, they can create a new workspace with these changes (almost like git checkout -b <branch_name> behaviour)
• Review mode:
  • Disable editing, playing around is good, but editing is not in this mode, it's confusing, probably -> we, however, can give people the choice to create a workspace from this branch though - which might need some SDLC work
  • Disable saving/review/Workspace updater
• Query builder viewer mode - this is the base for the standalone query builder
  • Disable editing everything, everything would be read-only (similar to the current viewer mode)

---

The current implementation is not bad, what we should do, however, is to add boolean flags when we configure EditorStore for the first time instead of relying on the flags like isInViewerMode, etc.