Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Enumeration mapping editor do not cleanup stubbed value mappings #1237

Closed
2 tasks done
akphi opened this issue Jun 25, 2022 · 0 comments · Fixed by #1236
Closed
2 tasks done

Bug: Enumeration mapping editor do not cleanup stubbed value mappings #1237

akphi opened this issue Jun 25, 2022 · 0 comments · Fixed by #1236
Assignees
@akphi
Labels
Studio Core Team Opened by a member of the Studio core team Type: Bug Type: Regression A bug that did not exist in previous versions
Milestone
7.0.0

Comments

@akphi
Copy link
Contributor

akphi commented Jun 25, 2022

Similar issues

  • I have searched and found no existing similar issues

How are you using Studio?

Legend Studio

Current and expected behavior

When creating a new enumeration mapping, we auto-fill the values with stubbed enum value mappings, but it seems that we don't properly clean these up, causing issue. See the following video

Screen.Recording.2022-06-24.at.11.29.14.PM.mov

This is a regression likely caused by the refactoring of Stubable - #1159

Steps to reproduce

No response

Model data

Enum model::SomeEnum
{
  VAL1,
  VAL2,
  VAL3
}


###Mapping
Mapping model::SomeMapping
(
  model::SomeEnum: EnumerationMapping
  {
  }
)

Environment

No response

Possible solution and workaround

No response

Contribution

  • I would like to work on the fix for this issue
@akphi akphi added Type: Bug Type: Regression A bug that did not exist in previous versions labels Jun 25, 2022
@akphi akphi added this to the 7.0.0 milestone Jun 25, 2022
@akphi akphi self-assigned this Jun 25, 2022
@github-actions github-actions bot added the Studio Core Team Opened by a member of the Studio core team label Jun 25, 2022
@akphi akphi mentioned this issue Jun 25, 2022
Merged
11 tasks
akphi added a commit to akphi/legend-studio that referenced this issue Jun 25, 2022
@akphi
fix enum-value mapping stub checker finos#1237
8308d62
MauricioUyaguari pushed a commit that referenced this issue Jun 25, 2022
@akphi
cleanups and bug fixes (#1236)
ed3da13 
* cleanup post #893

* minor adjustments to auto-complete suggestions

* more mapping modularization

* use OptionalEnumerationMappingReference for property mapping transformer

* more reference refactor

* remove V1_transformElementReference

* bump dependencies

* minor fixes

* add changeset

* fix enum-value mapping stub checker #1237

* dsl-text: make Text.type optional
@github-actions github-actions bot mentioned this issue Jun 25, 2022
Merged
jinanisha pushed a commit to jinanisha/legend-studio that referenced this issue Aug 5, 2022
@akphi
cleanups and bug fixes (finos#1236)
f2b2571 
* cleanup post finos#893

* minor adjustments to auto-complete suggestions

* more mapping modularization

* use OptionalEnumerationMappingReference for property mapping transformer

* more reference refactor

* remove V1_transformElementReference

* bump dependencies

* minor fixes

* add changeset

* fix enum-value mapping stub checker finos#1237

* dsl-text: make Text.type optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akphi akphi

Labels
Studio Core Team Opened by a member of the Studio core team Type: Bug Type: Regression A bug that did not exist in previous versions
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

cleanups and bug fixes akphi/legend-studio
1 participant
@akphi