Lionel Smith-Gordon Phase-1-Asset-Refactor - Release PR #3022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phase-1-Asset-Refactor
…tps://github.com/rosetta-models/common-domain-model into lionel_auth0_65080e6e10b98cc73ac44ca1-Phase1-ART
Updates from feedback and reviews
Updates to ListedDerivative
documentation updates
Change to Rune DSL
Updates to introduce the changes in this PR
✅ Deploy Preview for finos-cdm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chrisisla
reviewed
Jul 4, 2024
chrisisla
reviewed
Jul 4, 2024
chrisisla
reviewed
Jul 4, 2024
rosetta-source/src/main/rosetta/base-staticdata-asset-common-type.rosetta
Outdated
Show resolved
Hide resolved
chrisisla
reviewed
Jul 4, 2024
rosetta-source/src/main/rosetta/base-staticdata-asset-common-type.rosetta
Outdated
Show resolved
Hide resolved
chrisisla
reviewed
Jul 4, 2024
rosetta-source/src/main/rosetta/base-staticdata-asset-common-type.rosetta
Show resolved
Hide resolved
chrisisla
reviewed
Jul 4, 2024
chrisisla
reviewed
Jul 4, 2024
chrisisla
reviewed
Jul 4, 2024
chrisisla
previously approved these changes
Jul 8, 2024
Update to InstrumentBase to change condition
updated documentation for change to InstrumentBase
Code snippet for TransferBase updated
…lionel-Phase1-ART-release
lolabeis
reviewed
Jul 11, 2024
lolabeis
reviewed
Jul 11, 2024
lolabeis
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Approved at the CDM Contribution Review Working Group - July 2nd, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.