-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CVE scanning #2561
Merged
Merged
Fix CVE scanning #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for finos-cdm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SimonCockx
commented
Dec 1, 2023
@@ -3,6 +3,8 @@ name: CVE Scanning for Maven | |||
on: | |||
workflow_dispatch: | |||
push: | |||
branches: | |||
- master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filter push
events on master to prevent triggering CVE scanning twice.
The triggers now work as follows:
- The
pull_request
event makes sure that PRs must always succeed CVE scanning. - The
push
event filtered onmaster
will run CVE scanning on the master branch every time that it changes, as an additional check.
hugohills-regnosys
approved these changes
Dec 1, 2023
hugohills-regnosys
pushed a commit
to rosetta-models/common-domain-model
that referenced
this pull request
Dec 1, 2023
* Fixed CVE scan * Added JAVA_HOME env * Fixed versioning * Fixed versioning * Fixed versioning
hugohills-regnosys
added a commit
that referenced
this pull request
Dec 1, 2023
hugohills-regnosys
added a commit
that referenced
this pull request
Dec 1, 2023
* Update RELEASE.md * Update RELEASE.md * Update RELEASE.md * Update RELEASE.md * Add PR link * Fix CVE scanning (#2561) * Fixed CVE scan * Added JAVA_HOME env * Fixed versioning * Fixed versioning * Fixed versioning * Prevent GitHub Actions from being triggered twice (#2559) * Corrected action workflows * Test * Test * Fixed * Cleaned * Prevent GitHub Actions from being triggered twice (#2559) * Corrected action workflows * Test * Test * Fixed * Cleaned * Restored release.md * Restored release.md --------- Co-authored-by: JayasriR <124573358+JayasriR@users.noreply.github.com> Co-authored-by: Hugo Hills <39260692+hugohills-regnosys@users.noreply.github.com> Co-authored-by: eacunaISDA <82891014+eacunaISDA@users.noreply.github.com> Co-authored-by: lolabeis <leo.labeis@regnosys.com>
hugohills-regnosys
added a commit
that referenced
this pull request
Dec 1, 2023
* Fix CVE scanning (#2561) (#2562) * Fixed CVE scan * Added JAVA_HOME env * Fixed versioning * Fixed versioning * Fixed versioning Co-authored-by: SimonCockx <47859223+SimonCockx@users.noreply.github.com> * DSL Update (#2550) * Updated DSL * Updated DSL * Updated DSL * Updated expectations * Cleaned * Updated expectations * Updated expectations * Cleaned * Improved release notes * Improved release notes * Improved release notes --------- Co-authored-by: Hugo Hills <39260692+hugohills-regnosys@users.noreply.github.com> * 5xx Prevent GitHub Actions from being triggered twice (#2559) (#2563) * Update RELEASE.md * Update RELEASE.md * Update RELEASE.md * Update RELEASE.md * Add PR link * Fix CVE scanning (#2561) * Fixed CVE scan * Added JAVA_HOME env * Fixed versioning * Fixed versioning * Fixed versioning * Prevent GitHub Actions from being triggered twice (#2559) * Corrected action workflows * Test * Test * Fixed * Cleaned * Prevent GitHub Actions from being triggered twice (#2559) * Corrected action workflows * Test * Test * Fixed * Cleaned * Restored release.md * Restored release.md --------- Co-authored-by: JayasriR <124573358+JayasriR@users.noreply.github.com> Co-authored-by: Hugo Hills <39260692+hugohills-regnosys@users.noreply.github.com> Co-authored-by: eacunaISDA <82891014+eacunaISDA@users.noreply.github.com> Co-authored-by: lolabeis <leo.labeis@regnosys.com> --------- Co-authored-by: Hugo Hills <39260692+hugohills-regnosys@users.noreply.github.com> Co-authored-by: JayasriR <124573358+JayasriR@users.noreply.github.com> Co-authored-by: eacunaISDA <82891014+eacunaISDA@users.noreply.github.com> Co-authored-by: lolabeis <leo.labeis@regnosys.com>
hugohills-regnosys
added a commit
to rosetta-models/common-domain-model
that referenced
this pull request
Dec 1, 2023
This reverts commit 42aedde.
hugohills-regnosys
added a commit
that referenced
this pull request
Dec 1, 2023
* Update RELEASE.md * Update RELEASE.md * Update RELEASE.md * Update RELEASE.md * Add PR link * Updated Qualifying functions for Known Amount ZC Updated the qualifying functions and synonym mappings for Known Amount ZC Swaps. * Fix CVE scanning (#2561) * Fixed CVE scan * Added JAVA_HOME env * Fixed versioning * Fixed versioning * Fixed versioning * Prevent GitHub Actions from being triggered twice (#2559) * Corrected action workflows * Test * Test * Fixed * Cleaned * Updated Qualifying functions for Known Amount ZC 2 Updated the Qualifying functions for Known Amount Zero Coupon Swaps. * Revert "Prevent GitHub Actions from being triggered twice (#2559)" This reverts commit b297b46. * Revert "Fix CVE scanning (#2561)" This reverts commit 42aedde. * Fix release notes * Add release note * Fix syntax validation error and update docs code snippet * Update PR --------- Co-authored-by: JayasriR <124573358+JayasriR@users.noreply.github.com> Co-authored-by: eacunaISDA <82891014+eacunaISDA@users.noreply.github.com> Co-authored-by: lolabeis <leo.labeis@regnosys.com> Co-authored-by: Marc Gratacos <mgratacos@tradeheader.com> Co-authored-by: SimonCockx <47859223+SimonCockx@users.noreply.github.com>
hugohills-regnosys
added a commit
that referenced
this pull request
Jan 24, 2024
* TH_Valuation_Instruction Native representation and qualification of an update of the valuation. * ValuationInstruction now contains the replace flag. Create_Valuation only contains the instruction + tradeState as input arguments similar to other primitives * Fix CVE scanning (#2561) (#2562) * Fixed CVE scan * Added JAVA_HOME env * Fixed versioning * Fixed versioning * Fixed versioning Co-authored-by: SimonCockx <47859223+SimonCockx@users.noreply.github.com> * Added Valuation update release notes into RELEASE.md * DSL Update (#2550) * Updated DSL * Updated DSL * Updated DSL * Updated expectations * Cleaned * Updated expectations * Updated expectations * Cleaned * Improved release notes * Improved release notes * Improved release notes --------- Co-authored-by: Hugo Hills <39260692+hugohills-regnosys@users.noreply.github.com> * 5xx Prevent GitHub Actions from being triggered twice (#2559) (#2563) * Update RELEASE.md * Update RELEASE.md * Update RELEASE.md * Update RELEASE.md * Add PR link * Fix CVE scanning (#2561) * Fixed CVE scan * Added JAVA_HOME env * Fixed versioning * Fixed versioning * Fixed versioning * Prevent GitHub Actions from being triggered twice (#2559) * Corrected action workflows * Test * Test * Fixed * Cleaned * Prevent GitHub Actions from being triggered twice (#2559) * Corrected action workflows * Test * Test * Fixed * Cleaned * Restored release.md * Restored release.md --------- Co-authored-by: JayasriR <124573358+JayasriR@users.noreply.github.com> Co-authored-by: Hugo Hills <39260692+hugohills-regnosys@users.noreply.github.com> Co-authored-by: eacunaISDA <82891014+eacunaISDA@users.noreply.github.com> Co-authored-by: lolabeis <leo.labeis@regnosys.com> * Remove already released release note * Update RELEASE.md * Update RELEASE.md * Update RELEASE.md * Marc Gratacos Updated Qualifying functions for Known Amount ZC (#2571) * Update RELEASE.md * Update RELEASE.md * Update RELEASE.md * Update RELEASE.md * Add PR link * Updated Qualifying functions for Known Amount ZC Updated the qualifying functions and synonym mappings for Known Amount ZC Swaps. * Fix CVE scanning (#2561) * Fixed CVE scan * Added JAVA_HOME env * Fixed versioning * Fixed versioning * Fixed versioning * Prevent GitHub Actions from being triggered twice (#2559) * Corrected action workflows * Test * Test * Fixed * Cleaned * Updated Qualifying functions for Known Amount ZC 2 Updated the Qualifying functions for Known Amount Zero Coupon Swaps. * Revert "Prevent GitHub Actions from being triggered twice (#2559)" This reverts commit b297b46. * Revert "Fix CVE scanning (#2561)" This reverts commit 42aedde. * Fix release notes * Add release note * Fix syntax validation error and update docs code snippet * Update PR --------- Co-authored-by: JayasriR <124573358+JayasriR@users.noreply.github.com> Co-authored-by: eacunaISDA <82891014+eacunaISDA@users.noreply.github.com> Co-authored-by: lolabeis <leo.labeis@regnosys.com> Co-authored-by: Marc Gratacos <mgratacos@tradeheader.com> Co-authored-by: SimonCockx <47859223+SimonCockx@users.noreply.github.com> * Bataller García Eric Deprecated use of personRole in NaturalPerson type (#2576) * Deprecated use of personRole in NaturalPerson type The NaturalPerson type contains the attribute personRole of type NaturalPersonRole, which references back to the containing type of NaturalPerson, causing a circular reference in the model. Its use has been deprecated. * Update RELEASE.md * Update RELEASE.md * Update RELEASE.md --------- Co-authored-by: Bataller García Eric <ebataller@tradeheader.com> Co-authored-by: ebataller <128476578+ebataller@users.noreply.github.com> Co-authored-by: Payal Khanna <107400406+PayalKhanna@users.noreply.github.com> * Update ISO country code to keep in sync with latest ISO list (#2605) * [5.x.x] Update CDM to use DSL version 9.3.0 (#2606) * Update ISO country code to keep in sync with latest ISO list * Update DSL version to 9.3.0 and bundle version to 9.4.0 * [5.x.x] BUG-560: Bond forwards do not qualify (#2603) * Fix bond fwd qualification and add bond fwd samples and mappings * Merge release note * Update ISO country code to keep in sync with latest ISO list * Update RELEASE.md * Update RELEASE.md --------- Co-authored-by: eacunaISDA <82891014+eacunaISDA@users.noreply.github.com> * update bundle version 5 x x (#2615) * update bundle version * update RELEASE.md * updated ingestion.Json * format 5xx (#2619) format 5xx * Update DSL version to 9.3.1 (#2626) * FRO_Mappings_Update_prod FRO_Mappings_Update_prod * PTRR_Mappings_prod PTRR_Mappings_prod * added Release Note * FRO_Mappings_Update_prod * Update RELEASE.md * added Release Note and updated expectations * Update RELEASE.md * DSL update * Release notes correction --------- Co-authored-by: Georgina Tarres <gtarres@tradeheader.com> Co-authored-by: m_martos <mmartos@tradeheader.com> Co-authored-by: Hugo Hills <39260692+hugohills-regnosys@users.noreply.github.com> Co-authored-by: JayasriR <124573358+JayasriR@users.noreply.github.com> Co-authored-by: eacunaISDA <82891014+eacunaISDA@users.noreply.github.com> Co-authored-by: lolabeis <leo.labeis@regnosys.com> Co-authored-by: hugohills-regnosys <hugo.hills@regnosys.com> Co-authored-by: Marc Gratacos <mgratacos@tradeheader.com> Co-authored-by: regnosys-prod-user <67386743+regnosys-prod-user@users.noreply.github.com> Co-authored-by: Bataller García Eric <ebataller@tradeheader.com> Co-authored-by: ebataller <128476578+ebataller@users.noreply.github.com> Co-authored-by: Payal Khanna <107400406+PayalKhanna@users.noreply.github.com> Co-authored-by: Jan Baserba <jbaserba@tradeheader.com> Co-authored-by: PayalKhanna <payal.khanna@regnosys.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Category: Technical/Dependency
Pull requests that update a dependency file - Individual Maintainers May Approve
Complexity: Small/Bug/Mapping
Something isn't working - Requires one TA approval
Criticality: High
Target: Development
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.