Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out why Encode[Exception] is often not picked up #547

Closed
vkostyukov opened this issue Mar 2, 2016 · 1 comment
Closed

Figure out why Encode[Exception] is often not picked up #547

vkostyukov opened this issue Mar 2, 2016 · 1 comment
Labels
bug
Milestone
Finch 1.0

Comments

@vkostyukov
Copy link
Collaborator

Somehow the default instances from the Decode companion object is used. I guess it's something about priority. Hopefully there is a way to make it more pleasant for users. Right now they have to define an instance of Encode[Exception] right before the call to .toService.
@vkostyukov vkostyukov added the bug label Mar 2, 2016
@vkostyukov vkostyukov added this to the Finch 0.11 milestone Mar 2, 2016
@vkostyukov vkostyukov changed the title Figure out why Decode[Exception] is often not picked up Figure out why Encode[Exception] is often not picked up Mar 2, 2016
@vkostyukov vkostyukov modified the milestones: Finch 1.0, Finch 0.11 Mar 28, 2016
ilya-murzinov added a commit to ilya-murzinov/finch that referenced this issue Apr 20, 2016
@ilya-murzinov
Fix finagle#547: Change priority of built-in Encode[Exception] instances
729f2fb
@ilya-murzinov ilya-murzinov mentioned this issue Apr 20, 2016
Closed
@vkostyukov
Copy link
Collaborator Author

Lots of changed around exceptions so I'm closing until reported again.

@sergeykolbasov sergeykolbasov mentioned this issue Oct 8, 2017
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Finch 1.0
Development

No branches or pull requests
1 participant
@vkostyukov