Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): split query should be able to run when step > (end - start) #1924

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

Boyuan-Yu
Copy link
Contributor

@Boyuan-Yu Boyuan-Yu commented Jan 2, 2025

Pull Request checklist

  • The commit(s) message(s) follows the contribution guidelines ?
  • Tests for the changes have been added (for bug fixes / features) ?
  • Docs have been added / updated (for bug fixes / features) ?

Current behavior :
When we have a query that cross the namespace migration point, it's trying to stitch two series from two partitions. The first partition gives the time range (start, start + step), the end time of this range is larger than the end time of the query so it gives this error:

"requirement failed: start 1724457600000 should be <= end 1724457599000"

New behavior :
The query has one exec plan for the partition before the split. No need to stitch.

@Boyuan-Yu Boyuan-Yu changed the title fix(quert): split query should be able to run when step > (end - start) fix(query): split query should be able to run when step > (end - start) Jan 2, 2025
@Boyuan-Yu Boyuan-Yu marked this pull request as ready for review January 3, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant