feat(query): Adding support of optimize_with_agg logical plan to make use of aggregated metrics in HQE #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeep6189
previously approved these changes
Jan 3, 2025
coordinator/src/main/scala/filodb.coordinator/queryplanner/DefaultPlanner.scala
Outdated
Show resolved
Hide resolved
sandeep6189
previously approved these changes
Jan 3, 2025
sandeep6189
approved these changes
Jan 4, 2025
coordinator/src/main/scala/filodb.coordinator/queryplanner/DefaultPlanner.scala
Outdated
Show resolved
Hide resolved
coordinator/src/main/scala/filodb.coordinator/queryplanner/DefaultPlanner.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR introduces support for the optimize_with_agg function in the Logical Plan. The optimize_with_agg function is a no-operation (no-op) that is used in conjunction with aggregation queries. It ensures that the optimization logic is preserved and applied correctly during the aggregation phase without interfering with the underlying data or query execution flow. This enhancement allows users to pass queries with optimize_with_agg and see a proper Logical Plan with the correct tree structure.
What Does This PR Do?
optimize_with_aggto MiscellaneousFunctionId.optimize_with_agg.OPTIMIZE_WITH_AGG.optimize_with_aggas a no-op.optimize_with_agg.Pull Request checklist
Current behavior :
Unsupported optimize_with_agg Function
New behavior :
Supported optimize_with_agg Function