Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): Raw data export with StitchRvsExec correctly sets the rawSource value in PeriodicSamplesMapper RVT #1920

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

sandeep6189
Copy link
Contributor

@sandeep6189 sandeep6189 commented Dec 23, 2024

Pull Request checklist

  • The commit(s) message(s) follows the contribution guidelines ?
  • Tests for the changes have been added (for bug fixes / features) ?
  • Docs have been added / updated (for bug fixes / features) ?

Current behavior : Bug: rawSource in PeriodicSamplesMapper RVT, is incorrectly set to false leading to failed histogram queries during remote raw export

New behavior : rawSource is set to true for the PeriodicSamplesMapper RVT allowing for queries to go through.

@sandeep6189 sandeep6189 changed the title Setting rawSource to true and fixing the unit tests fix(query): Raw data export with StitchRvsExec correctly sets the rawSource value in PeriodicSamplesMapper RVT Dec 24, 2024
Copy link
Contributor

@amolnayak311 amolnayak311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @sandeep6189

@sandeep6189 sandeep6189 merged commit 0999aec into filodb:develop Jan 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants