Support Partition Assignment V2. #1917
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82f0f45 to
8fb4fa3
Compare
Create a trait class PartitionAssignmentTrait to support both V1 and V2 assignemnt. Query service has to re-compile but does not have to change anything. For single partition assignment queries, the behavior does not change. For multiple partition assignment queries without partition assignment change, use MultiPartitionDistConcatExec to assemble all time series. For multiple partition assignment queries with partition assignment, stitch the time series before and after changes.
sandeep6189
reviewed
Dec 20, 2024
| @@ -22,15 +22,34 @@ import filodb.query.LogicalPlan._ | |||
| import filodb.query.exec._ | |||
|
|
|||
| //scalastyle:off file.size.limit | |||
| case class PartitionDetails(partitionName: String, httpEndPoint: String, | |||
| grpcEndPoint: Option[String], proportion: Float) | |||
| trait PartitionAssignmentTrait { | |||
There was a problem hiding this comment.
nitpick: maybe we can add a Scala doc for the trait to just outline the use of proportionMap, timerange and some examples ?
| => (pa.partitionName, params.startSecs * 1000L, | ||
| params.endSecs * 1000L, pa.grpcEndPoint) | ||
| case Some(pa: PartitionAssignmentTrait) | ||
| => (pa.proportionMap.keys.head, params.startSecs * 1000L, |
There was a problem hiding this comment.
nitpick: should we add a simple helper function in PartitionAssignmentTrait to get the keys and values of proportionMap ?
| @@ -388,24 +407,46 @@ class MultiPartitionPlanner(val partitionLocationProvider: PartitionLocationProv | |||
| PlanResult(execPlan:: Nil) | |||
| } | |||
|
|
|||
| private def materializeForPartition(logicalPlan: LogicalPlan, | |||
There was a problem hiding this comment.
nitpick: please add a Scala doc
sandeep6189
reviewed
Dec 20, 2024
| val proportionMap: Map[String, PartitionDetails] = | ||
| Map(partitionName -> PartitionDetails(partitionName, httpEndPoint, grpcEndPoint, 1.0f)) | ||
| } | ||
| case class PartitionAssignmentV2(proportionMap: Map[String, PartitionDetails], |
There was a problem hiding this comment.
should we add an assertion in PartitionAssignmentV2 such that all the proportion in proportionMap will sum up to 1.0f ?
|
|
||
| execPlan.isInstanceOf[StitchRvsExec] shouldEqual (true) | ||
| // Should have two MultiPartitionDistConcatExec for before and after assignment change. | ||
| execPlan.children.count(plan => plan.isInstanceOf[MultiPartitionDistConcatExec]) shouldEqual 2 |
There was a problem hiding this comment.
Thank you for adding good unit tests @yu-shipit 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a trait class PartitionAssignmentTrait to support both V1 and V2 assignemnt. Query service has to re-compile but does not have to change anything. For single partition assignment queries, the behavior does not change. For multiple partition assignment queries without partition assignment change, use MultiPartitionDistConcatExec to assemble all time series. For multiple partition namespace queries with partition assignment, stitch the time series before and after changes.
Pull Request checklist
Current behavior : (link exiting issues here : https://help.github.com/articles/basic-writing-and-formatting-syntax/#referencing-issues-and-pull-requests)
New behavior :
Filodb can support queries for multi-partitioned assignment.
Add two APIs for supporting that.
getPartitionsandgetMetadataPartitionsTraitare deprecated but still can be used for backwards compatibility.BREAKING CHANGES
Breaking changes may include:
Other information: