Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(query): Adding helper functions for hqe #1883

Merged
merged 1 commit into from
Nov 9, 2024
Merged

misc(query): Adding helper functions for hqe #1883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions coordinator/src/main/scala/filodb.coordinator/queryplanner/LogicalPlanUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,14 @@ object LogicalPlanUtils extends StrictLogging {
}
}

/**
* @param logicalPlan LogicalPlan
* @return maximum offset in milliseconds
*/
def getMaxOffetInMillis(logicalPlan: LogicalPlan): Long = {
getOffsetMillis(logicalPlan).max
}

def getLookBackMillis(logicalPlan: LogicalPlan): Seq[Long] = {
// getLookBackMillis is used primarily for LongTimeRangePlanner,
// SubqueryWtihWindowing returns lookback but TopLevelSubquery does not. The conceptual meaning of the lookback
Expand All @@ -260,6 +268,14 @@ object LogicalPlanUtils extends StrictLogging {
}
}

/**
* @param logicalPlan LogicalPlan
* @return maximum lookback in milliseconds
*/
def getMaxLookBackInMillis(logicalPlan: LogicalPlan): Long = {
getLookBackMillis(logicalPlan).max
}

def getMetricName(logicalPlan: LogicalPlan, datasetMetricColumn: String): Set[String] = {
val columnFilterGroup = LogicalPlan.getColumnFilterGroup(logicalPlan)
val metricName = LogicalPlan.getColumnValues(columnFilterGroup, PromMetricLabel)
Expand Down
26 changes: 26 additions & 0 deletions coordinator/src/test/scala/filodb.coordinator/queryplanner/LogicalPlanUtilsSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,4 +155,30 @@ class LogicalPlanUtilsSpec extends AnyFunSpec with Matchers {
counts._1 shouldEqual 1
counts._2 shouldEqual 0
}

it ("getMaxOffetInMillis should return result as expected") {
val timeParamsSec = TimeStepParams(1000, 10, 10000)
val query1 = """rate(test_metric{_ns_="test-ns", _ws_="test-ns", cluster="test1"}[5m]) * 1000"""
val query2 = """rate(test_metric{_ns_="test-ns", _ws_="test-ns", cluster="test1"}[5m] offset 1h) + rate(test_metric{_ns_="test-ns", _ws_="test-ns", cluster="test1"}[5m] offset 2h)"""

def getMaxOffsetInMillis(query: String) : Long = {
val lp = Parser.queryRangeToLogicalPlan(query, timeParamsSec)
LogicalPlanUtils.getMaxOffetInMillis(lp)
}
getMaxOffsetInMillis(query1) shouldEqual 0
getMaxOffsetInMillis(query2) shouldEqual 7200000
}

it ("getMaxLookbackInMillis should return result as expected") {
val timeParamsSec = TimeStepParams(1000, 10, 10000)
val query1 = """rate(test_metric{_ns_="test-ns", _ws_="test-ns", cluster="test1"}[15m]) + rate(test_metric{_ns_="test-ns", _ws_="test-ns", cluster="test1"}[10m])"""
val query2 = """test_metric{_ns_="test-ns", _ws_="test-ns", cluster="test1"} offset 1d * 1000"""

def getMaxLookbackInMillis(query: String) : Long = {
val lp = Parser.queryRangeToLogicalPlan(query, timeParamsSec)
LogicalPlanUtils.getMaxLookBackInMillis(lp)
}
getMaxLookbackInMillis(query1) shouldEqual 900000 // max of 15 and 10m
getMaxLookbackInMillis(query2) shouldEqual 300000 // default lookback is 5m
}
}
Loading