Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clients.snssqs refactorings #91

Merged
merged 18 commits into from
Nov 5, 2023
Merged

clients.snssqs refactorings #91

merged 18 commits into from
Nov 5, 2023

Conversation

filipsnastins
Copy link
Owner

@filipsnastins filipsnastins commented Nov 4, 2023 •
edited
Loading

Updates

  • clients.snssqs: added cache for storing topic/queue ARNs and URLs to reduce amount of API calls to AWS
  • clients.snssqs: added new methods for fetching topic/queue attributes:
    • get_topic_arn
    • get_topic_attributes
    • get_queue_arn
    • get_queue_url
    • get_queue_attributes
  • clients.snssqs: added purge_queue method

Breaking changes

  • DockerContainer.restart_container method renamed to DockerContainer.restart

@filipsnastins
refactor(clients.snssqs): rename module snssqs_client -> snssqs
f093820
@filipsnastins
chore: fix test coverage collection
8d19990
@filipsnastins
feat(clients.snssqs): add topic and queue attribute getters
c1e2455
@filipsnastins
style(clients.snsqs): use dict instead of mapping type
1b6162a
@filipsnastins
chore(deps): poetry update
3d18ee8
@filipsnastins
refactor(clients.snssqs): make aiobotocore clients private
af5019b
@filipsnastins
test(clients.snssqs): rename test file to test_snssqs
e4bdc7e
@filipsnastins
feat(clients.snssqs): introduce cache for getting topic and queue arn…
51e01be 
…/url
@filipsnastins
test: add event_loop fixture
206ef9b
@filipsnastins
refactor(pytest.fixtures): make client fixtures session scoped
c9b9c04
@filipsnastins
chore: configure test coverage report
e88149d
@filipsnastins
feat(clients.snssqs): add purge_queue method
19dc0b6
@filipsnastins
refactor: remove moto_snssqs_tc and localstack_snssqs_tc fixtures
522251b
@filipsnastins
refactor: require kw-only args
9082d2c
@filipsnastins
test: improve test speed - start tomodachi container once per service…
c9c87f6 
… test
@filipsnastins
test: rename test data folders to match test name
65daa61
@filipsnastins
test: use pytest.mark.usefixtures instead of autouse
f228c55
@filipsnastins
fix(pytest.fixtures): return moto_snssqs_tc and localstack_snssqs_tc …
e6985a6 
…fixtures
@filipsnastins filipsnastins changed the title Refactor/snssqs client clients.snssqs refactorings Nov 5, 2023
@filipsnastins filipsnastins marked this pull request as ready for review November 5, 2023 10:09
@filipsnastins filipsnastins merged commit 54d6700 into main Nov 5, 2023
@filipsnastins filipsnastins deleted the refactor/snssqs-client branch November 16, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@filipsnastins