Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log message on container start #90

Merged
merged 14 commits into from
Nov 4, 2023

Conversation

filipsnastins
Copy link
Owner

@filipsnastins filipsnastins commented Nov 4, 2023

DockerContainer is an abstract class that provides an abstract method log_message_on_container_start.

The message will be logger on DockerContainer.start

Example:

class TomodachiContainer(DockerContainer):
    def __init__(
        self,
        ...
    ) -> None:
        ...

    def log_message_on_container_start(self) -> str:
        return f"Tomodachi service: http://localhost:{self.edge_port}"

Breaking changes:

  • DockerContainer.restart_container method renamed to DockerContainer.restart

@filipsnastins filipsnastins changed the title Refactor/container startup message Log message on container start Nov 4, 2023
@filipsnastins filipsnastins marked this pull request as ready for review November 4, 2023 09:13
@filipsnastins filipsnastins merged commit fcc48e2 into main Nov 4, 2023
@filipsnastins filipsnastins deleted the refactor/container-startup-message branch November 16, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant