Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feature) Disable logging with environment variable #305

Merged
merged 5 commits into from
May 14, 2024

Conversation

filipsnastins
Copy link
Owner

@filipsnastins filipsnastins commented May 14, 2024

Logs from some containers are not often useful, for example, Moto container logs are simple HTTP access logs that are not immediately helpful for debugging.

To reduce clutter in stdout, add <CONTAINER-NAME>_TESTCONTAINER_DISABLE_LOGGING envvars that allow to selectively disable log forwarding to stdout, e.g., MOTO_TESTCONTAINER_DISABLE_LOGGING=1.

Example:

Without MOTO_TESTCONTAINER_DISABLE_LOGGING=1:
image

With MOTO_TESTCONTAINER_DISABLE_LOGGING=1:
image

@filipsnastins filipsnastins self-assigned this May 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.60%. Comparing base (fc6d575) to head (aad70ec).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
+ Coverage   97.58%   97.60%   +0.02%     
==========================================
  Files          74       74              
  Lines        2240     2259      +19     
  Branches      327      329       +2     
==========================================
+ Hits         2186     2205      +19     
  Misses         44       44              
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@filipsnastins filipsnastins marked this pull request as ready for review May 14, 2024 12:14
@filipsnastins filipsnastins merged commit e3f5b4d into main May 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants