Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feature) SNSSQS Test Client: receive message attributes #180

Merged

Conversation

filipsnastins
Copy link
Owner

@filipsnastins filipsnastins commented Jan 24, 2024

SNSSQSTestClient.receive now returns the SQSMessage dataclass wrapper containing payload and message_attributes fields.

It's useful to test that the correct message_attributes are set on the published messages, so we need to return it once we receive a message.

This is a minor breaking change in the SNSSQSTestClient.receive function. Now, the message payload needs to be accessed with the payload property.

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4b94d72) 97.25% compared to head (54575ef) 97.27%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   97.25%   97.27%   +0.01%     
==========================================
  Files          73       73              
  Lines        2223     2236      +13     
  Branches      330      332       +2     
==========================================
+ Hits         2162     2175      +13     
  Misses         50       50              
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@filipsnastins filipsnastins changed the title Feature/snssqs test client receive message attributes (feature) SNSSQS Test Client: receive message attributes Jan 24, 2024
@filipsnastins filipsnastins self-assigned this Jan 24, 2024
@filipsnastins filipsnastins marked this pull request as ready for review January 24, 2024 14:23
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@filipsnastins filipsnastins merged commit 207f4a2 into main Jan 25, 2024
10 checks passed
@filipsnastins filipsnastins deleted the feature/snssqs-test-client-receive-message-attributes branch February 29, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants