Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clients.SNSSQSTestClient): add send sqs message method #169

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

filipsnastins
Copy link
Owner

@filipsnastins filipsnastins commented Jan 18, 2024

  • Adding a method SNSSQSTestClient.send for sending messages to SQS queues.

  • Removed redundant fifo argument and relied on that topic/queue names end with .fifo instead.

  • SNSSQSTestClient.receive now supports receiving messages directly from SQS, and not only SNS notifications over SQS.

@filipsnastins filipsnastins self-assigned this Jan 18, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4570a2a) 97.03% compared to head (ac86d54) 96.99%.

Files Patch % Lines
src/tomodachi_testcontainers/clients/snssqs.py 91.30% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   97.03%   96.99%   -0.05%     
==========================================
  Files          71       71              
  Lines        2160     2193      +33     
  Branches      324      331       +7     
==========================================
+ Hits         2096     2127      +31     
- Misses         50       51       +1     
- Partials       14       15       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@filipsnastins filipsnastins marked this pull request as ready for review January 18, 2024 13:07
@filipsnastins filipsnastins merged commit 886af08 into main Jan 18, 2024
9 checks passed
@filipsnastins filipsnastins deleted the feature/snssqs-test-client-send-sqs-message branch January 20, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants