Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not well formed language tags are accepted #151

Closed
filip26 opened this issue Apr 21, 2021 · 0 comments · Fixed by #153
Closed

Not well formed language tags are accepted #151

filip26 opened this issue Apr 21, 2021 · 0 comments · Fixed by #153
Labels
bug Something isn't working
Milestone
1.0.3

Comments

@filip26
Copy link
Owner

filip26 commented Apr 21, 2021

language tags containing more than just one '-' are accepted by the implementation:

titanium-json-ld/src/main/java/com/apicatalog/jsonld/lang/LanguageTag.java

Line 60 in 9abc55a

return Arrays.stream(chars, 1, chars.length - 1).allMatch(RdfAlphabet.ASCII_ALPHA_NUM.or(ch -> ch == '-'));

@filip26 filip26 added the bug Something isn't working label Apr 21, 2021
@filip26 filip26 added this to the 1.0.3 milestone Apr 22, 2021
filip26 added a commit that referenced this issue Apr 22, 2021
@filip26
add issue #151 test
2e63bfd
filip26 added a commit that referenced this issue Apr 22, 2021
@filip26
fix issue #151
cd8e551
@filip26 filip26 linked a pull request Apr 22, 2021 that will close this issue
Fix Issue #151 #153
Merged
filip26 added a commit that referenced this issue Apr 22, 2021
@filip26
Merge pull request #153 from filip26/fix/issue-151
f8d090c 
Fix Issue #151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.3
Development

Successfully merging a pull request may close this issue.

Fix Issue #151 filip26/titanium-json-ld
1 participant
@filip26