Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Merged all interop into Win32PInvoke #15209

Merged
merged 8 commits into from
May 1, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Apr 17, 2024

Summary

Just moved. Nothing has been modified other than formatting or adding extra references to avoid ambiguity.

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes #issue
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    None

Screenshots

None

@0x5bfa
Copy link
Member Author

0x5bfa commented Apr 17, 2024

This is the last time touching around interop classes.
Deleted all interop classes and merged into single class, so we now can gradually replace them with CsWin32 without conflict (there were some classes that have the same definition) in the single place.

It's a bit large but ready for review.

@0x5bfa 0x5bfa marked this pull request as ready for review April 17, 2024 01:36
Copy link
Contributor

@gumbarros gumbarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for this

Copy link
Contributor

@gumbarros gumbarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 1, 2024
@yaira2 yaira2 merged commit 8781bfa into files-community:main May 1, 2024
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/CQ-DeleteInteropClasses branch May 1, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants