Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality: Added Save dialog project #15208

Merged
merged 42 commits into from
Apr 17, 2024
Merged

Code Quality: Added Save dialog project #15208

merged 42 commits into from
Apr 17, 2024

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Apr 16, 2024 •
edited
Loading

TODO:

  • Enable only for debug mode

gave92 added 30 commits December 17, 2021 19:47
@gave92
Added CustomSaveDialog project
e961d0f
@gave92
Add initial implementation
7e8d74f
@gave92
[WIP]
6553c2e
@gave92
Enabled debug mode
57c0d49
@gave92
Implemented Show method
7bb3e45
@gave92
Add compilation dependency
663af70
@gave92
Build dll for 32bit
b707306
@gave92
Add support for selecting initial file
e2e508b
@gave92
[TEST] VS not working
dedf2e0
@gave92
Unrelated fixes
919aed6
@gave92
Merge branch "main"
3e15e8d
@gave92
Cleanup
46d1fc4
@gave92
Workaround for VS
e74a1f6
@gave92
Update proj structure
2349c9a
@gave92
Revert changes to language files
4520e3f
@gave92
Fix post build command
3fda690
@gave92
Add missing dll files to output dir
92834e2
@gave92
Merge branch 'main' of https://github.com/files-community/Files into …
9bf09bd 
…save_dialog
@gave92
Merge branch 'main' of https://github.com/files-community/Files into …
6966d81 
…save_dialog
@gave92
Fix build for new project
b538c8b
@gave92
Merge branch 'main' of https://github.com/files-community/Files into …
71c3c37 
…save_dialog
@gave92
Fixed sln config
0ef0be6
@gave92
Fix indentation
e6e7a41
@gave92
Update proj to VS2022
701a31c
@gave92
Merge branch 'main' of https://github.com/files-community/Files into …
1337e02 
…save_dialog
@gave92
WIP
046f57c
@gave92
WIP
def089e
@gave92
Compilation order
7581b01
@gave92
Fix save for notepad, implemented GetSelectedControlItem and GetPrope…
4ef4033 
…rties
@gave92
Fixed OnFileOk?? Call AddRef()
8e599ec
@0x5bfa 0x5bfa self-requested a review April 16, 2024 23:31
@yaira2 yaira2 changed the title Added Save dialog project Code Quality: Added Save dialog project Apr 16, 2024
yaira2
yaira2 previously approved these changes Apr 16, 2024
View reviewed changes
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Apr 16, 2024
0x5bfa
0x5bfa suggested changes Apr 16, 2024
View reviewed changes
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok overall.

@yaira2
Copy link
Member

yaira2 commented Apr 17, 2024

@gave92 LGTM

That said, on 23H2 this appears to crash Notepad for both opening and saving.

@yaira2 yaira2 merged commit 10b0690 into files-community:main Apr 17, 2024
6 checks passed
@gave92 gave92 deleted the save_dialog branch April 17, 2024 21:04
@gave92
Copy link
Member Author

gave92 commented Apr 17, 2024

Thanks! When you got time we can take a look to debug why it's not woking for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x5bfa 0x5bfa 0x5bfa requested changes

@yaira2 yaira2 yaira2 left review comments

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gave92 @yaira2 @0x5bfa