Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Added support for resizing columns in the column layout #13540

Closed
wants to merge 10 commits into from
Closed

Feature: Added support for resizing columns in the column layout #13540

wants to merge 10 commits into from

Conversation

Mohammed-619
Copy link

@Mohammed-619 Mohammed-619 commented Oct 19, 2023 •
edited
Loading

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Add support for resizing columns in the column layout #6534

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app
    2. Enter Desktop for example
    3. Choose Columns mode
    4. Try resizing the columns by holding the border and dragging it horizontally

Screenshots (optional)

@yaira2 yaira2 changed the title Feature: Add support for resizing columns in the column layout #6534 Feature: Added support for resizing columns in the column layout Oct 20, 2023
yaira2 and others added 3 commits October 20, 2023 12:36
@0x5bfa
Copy link
Member

0x5bfa commented Oct 21, 2023

@Mohammed-619 Thank you for your first contribution.

Please ensure you're using XAML Styler. If you've never used it, install it from the following list to follow our coding style guideline.

yaira2
yaira2 reviewed Oct 23, 2023
View reviewed changes
src/Files.App/Views/LayoutModes/ColumnViewBrowser.xaml
Comment on lines +37 to +41
ManipulationDelta="BladeItem_ManipulationDelta"
ManipulationMode="TranslateX"
ManipulationStarted="BladeItem_ManipulationStarted"
PointerExited="BladeItem_PointerExited"
PointerMoved="BladeItem_PointerMoved">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding these events directly to the blade, another approach might be to add them to a separate element within the blade. This would allow us to remove the extra padding from the frame. @chingucoding which approach do you think is better practice?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think similar to the SideBar, having a separate element would give us more flexibility in the long term. Accessibilitywise, if we also want to handle arrow keys, a separate element would also be better since you can have a dedicated UIA name for the resizer element.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I was thinking 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mohammed-619

@yaira2 yaira2 force-pushed the main branch 5 times, most recently from a827a37 to 20e04d0 Compare November 2, 2023 18:32
@yaira2 yaira2 force-pushed the main branch 3 times, most recently from cecddda to 7f8c927 Compare November 17, 2023 16:57
@yaira2
Copy link
Member

yaira2 commented Nov 26, 2023

Closing due to inactivity

@yaira2 yaira2 closed this Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelwgn marcelwgn marcelwgn left review comments

@yaira2 yaira2 yaira2 left review comments

Assignees
No one assigned
Labels
needs - code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Add support for resizing columns in the column layout
4 participants
@Mohammed-619 @0x5bfa @yaira2 @marcelwgn