Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed issue where GridSplitter style was missing on the details layout #10202

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Fix: Fixed issue where GridSplitter style was missing on the details layout #10202

merged 3 commits into from
Oct 14, 2022

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Comments
It seems this is a known bug of WinUI3.
This is a workaround to fix that.

Validation
How did you test these changes?

  • Built and ran the app

QuaintMako
QuaintMako reviewed Oct 14, 2022
View reviewed changes
Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside for the empty line to add, code LGTM!

Good idea to reorder the imports in alphabetical order.

@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Oct 14, 2022
yaira2
yaira2 approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Oct 14, 2022
@yaira2 yaira2 changed the title Fixed: GridSplitter style missing Fix: Fixed issue where GridSplitter style was missing on the details layout Oct 14, 2022
@yaira2 yaira2 merged commit 9a9b3bc into files-community:main Oct 14, 2022
@ferrariofilippo ferrariofilippo deleted the GridSplitter branch October 14, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuaintMako QuaintMako QuaintMako left review comments

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Details grid is missing the grid splitter style when resizing columns
3 participants
@ferrariofilippo @yaira2 @QuaintMako