Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make blockstore compatible with different cid of codex #5446

Conversation

LinZexiao
Copy link
Collaborator

@LinZexiao LinZexiao commented Nov 3, 2022

from different codex

关联的Issues (Related Issues)

close #5370

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@LinZexiao LinZexiao changed the title feat: make blockstore compatible with cid feat: make blockstore compatible with different cid of codex Nov 3, 2022
Copy link
Contributor

@diwufeiwen diwufeiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #5446 (48255a4) into master (766a934) will increase coverage by 0%.
The diff coverage is 62%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #5446   +/-   ##
======================================
  Coverage      24%     24%           
======================================
  Files         605     605           
  Lines       67852   67857    +5     
======================================
+ Hits        16883   16888    +5     
+ Misses      48781   48780    -1     
- Partials     2188    2189    +1     

@diwufeiwen diwufeiwen merged commit 908a4af into master Nov 3, 2022
@diwufeiwen diwufeiwen deleted the feat/tanlang/make-blockstore-compatible-with-defferent-codex-of-cid branch November 3, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[venus] blockstore正确处理codex fix?
4 participants