Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add timeout params for shared common test/共享的通用测试工作流中添加超时的参数. #5327

Merged
merged 2 commits into from
Sep 27, 2022
Merged

feat: add timeout params for shared common test/共享的通用测试工作流中添加超时的参数. #5327

merged 2 commits into from
Sep 27, 2022

Conversation

zl03jsj
Copy link
Contributor

@zl03jsj zl03jsj commented Sep 26, 2022

关联的Issues (Related Issues)

close

改动 (Proposed Changes)

  1. 在通用测试工作流中, 增加设置超时的参数.
  2. 当upload ftp失败是, 允许继续后面的job.
  3. 检查go mod tidy

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@zl03jsj zl03jsj requested a review from simlecode September 26, 2022 09:38
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+LGTM

@zl03jsj zl03jsj self-assigned this Sep 26, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #5327 (80d53c4) into master (93f8066) will decrease coverage by 0%.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #5327   +/-   ##
======================================
- Coverage      25%     25%   -1%     
======================================
  Files         587     587           
  Lines       65184   65184           
======================================
- Hits        16620   16613    -7     
- Misses      46390   46393    +3     
- Partials     2174    2178    +4     

@zl03jsj zl03jsj merged commit 877085b into filecoin-project:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants