Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 移除已失效命令 / remove unused cmds and dead code #5314

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

simlecode
Copy link
Collaborator

@simlecode simlecode commented Sep 21, 2022

关联的Issues (Related Issues)

close #5243

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@simlecode simlecode requested a review from hunjixin September 22, 2022 01:12
cmd/main.go Outdated Show resolved Hide resolved
@simlecode simlecode force-pushed the fix/remove_unused_cmds branch from 89fda40 to 6491c03 Compare September 22, 2022 05:40
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2022

Codecov Report

Merging #5314 (89fda40) into master (558cf39) will increase coverage by 0%.
The diff coverage is 0%.

❗ Current head 89fda40 differs from pull request most recent head c44b7e3. Consider uploading reports for the commit c44b7e3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #5314    +/-   ##
=======================================
  Coverage      25%     25%            
=======================================
  Files         589     586     -3     
  Lines       65576   65259   -317     
=======================================
  Hits        16574   16574            
+ Misses      46843   46526   -317     
  Partials     2159    2159            

@simlecode simlecode force-pushed the fix/remove_unused_cmds branch from 6491c03 to c44b7e3 Compare September 22, 2022 05:42
@simlecode simlecode force-pushed the fix/remove_unused_cmds branch from c44b7e3 to 8ea8ad4 Compare September 22, 2022 07:28
@hunjixin hunjixin merged commit ac95abb into master Sep 22, 2022
@hunjixin hunjixin deleted the fix/remove_unused_cmds branch September 22, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

venus去除或者优化已失效命令
4 participants