Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: Status display when sync is complete / 一些命令行显示的优化 #5313

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

diwufeiwen
Copy link
Contributor

@diwufeiwen diwufeiwen commented Sep 21, 2022

关联的Issues (Related Issues)

fix #5244

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@diwufeiwen diwufeiwen self-assigned this Sep 21, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #5313 (69195a1) into master (558cf39) will increase coverage by 0%.
The diff coverage is 0%.

❗ Current head 69195a1 differs from pull request most recent head d28e33b. Consider uploading reports for the commit d28e33b to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #5313   +/-   ##
======================================
  Coverage      25%     25%           
======================================
  Files         589     589           
  Lines       65576   65586   +10     
======================================
+ Hits        16574   16589   +15     
+ Misses      46843   46838    -5     
  Partials     2159    2159           

Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+LGTM

@simlecode simlecode merged commit 6afaaf6 into master Sep 22, 2022
@simlecode simlecode deleted the feat/cmds_opt branch September 22, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[venus] 同步到最新高度时 sync status 不显示信息
4 participants