Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use %w to wrap error #5286

Merged
merged 1 commit into from
Sep 15, 2022
Merged

fix: use %w to wrap error #5286

merged 1 commit into from
Sep 15, 2022

Conversation

simlecode
Copy link
Collaborator

@simlecode simlecode commented Sep 15, 2022

关联的Issues (Related Issues)

改动 (Proposed Changes)

fix: #5099

修复消息验证失败时,会全部分返回 pubsub.ValidationReject,导致peer被扣分

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@simlecode simlecode requested a review from hunjixin September 15, 2022 02:02
@codecov-commenter
Copy link

Codecov Report

Merging #5286 (f51abb8) into master (c603dbe) will decrease coverage by 0%.
The diff coverage is 0%.

@@          Coverage Diff           @@
##           master   #5286   +/-   ##
======================================
- Coverage      25%     25%   -1%     
======================================
  Files         589     589           
  Lines       65516   65516           
======================================
- Hits        16580   16574    -6     
- Misses      46780   46782    +2     
- Partials     2156    2160    +4     

@hunjixin hunjixin merged commit f8f1ba3 into master Sep 15, 2022
@hunjixin hunjixin deleted the fix/wrap_error branch September 15, 2022 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants