Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add type SignedStorageAsk into venus-shared/在venus-shared中添加SignedStorageAsk类型定义. #5280

Merged
merged 4 commits into from
Sep 9, 2022

Conversation

zl03jsj
Copy link
Contributor

@zl03jsj zl03jsj commented Sep 9, 2022

关联的Issues (Related Issues)

close #5276

改动 (Proposed Changes)

在venus-shared中增加自定义的SignedStorageAsk类型
本PR:
#5263 的的子任务

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@zl03jsj zl03jsj changed the title Feat/add signed storage ask Feat: add type SignedStorageAsk into venus-shared/在venus-shared中添加SignedStorageAsk类型定义. Sep 9, 2022
@zl03jsj zl03jsj self-assigned this Sep 9, 2022
@zl03jsj zl03jsj added the P2 Medium - we should get to this soon label Sep 9, 2022
@zl03jsj zl03jsj requested a review from LinZexiao September 9, 2022 06:15
diwufeiwen
diwufeiwen previously approved these changes Sep 9, 2022
Copy link
Contributor

@diwufeiwen diwufeiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2022

Codecov Report

Merging #5280 (88987d6) into master (33a27ea) will decrease coverage by 0%.
The diff coverage is 0%.

@@          Coverage Diff           @@
##           master   #5280   +/-   ##
======================================
- Coverage      25%     25%   -1%     
======================================
  Files         588     589    +1     
  Lines       65436   65516   +80     
======================================
- Hits        16565   16558    -7     
- Misses      46710   46797   +87     
  Partials     2161    2161           

Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@diwufeiwen diwufeiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@LinZexiao LinZexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zl03jsj zl03jsj merged commit c603dbe into master Sep 9, 2022
@zl03jsj zl03jsj deleted the feat/add_SignedStorageAsk branch September 9, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Medium - we should get to this soon
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[venus-shared] 在venus-share中增加包含自定义属性的SignedStorageAsk类型.
5 participants