Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make deps before make docker #5268

Merged
merged 3 commits into from
Sep 5, 2022
Merged

Conversation

LinZexiao
Copy link
Collaborator

@LinZexiao LinZexiao commented Sep 5, 2022

关联的Issues (Related Issues)

involve #5267

改动 (Proposed Changes)

  • make deps before make docker

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2022

Codecov Report

Merging #5268 (a263ae8) into master (edb9052) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5268   +/-   ##
======================================
  Coverage      25%     25%           
======================================
  Files         588     588           
  Lines       65127   65127           
======================================
+ Hits        16341   16343    +2     
+ Misses      46639   46636    -3     
- Partials     2147    2148    +1     

@LinZexiao LinZexiao force-pushed the fix/make-deps-bofore-make-docker branch from afc6be9 to 91b62a9 Compare September 5, 2022 07:55
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simlecode simlecode merged commit 693040c into master Sep 5, 2022
@simlecode simlecode deleted the fix/make-deps-bofore-make-docker branch September 5, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants