feat: implement fip-0029, support beneficiary #1571
Conversation
Some terms change, and WithdrawBalance method modification
Rephrase some wording & ChangeBeneficiary method modification
Feat/fip 0028
gen new determinism
There was a problem hiding this comment.
Given the representation of the beneficiary address always being non-nil, and equal to the owner address by default, we must update the beneficiary address when the owner address is changed, if they are equal. Also it's hard to think about various cases when a proposed beneficiary change is active. I think we should delete any proposal when the owner changes. Please fix ChangeOwnerAddress to do this.
review of beneficiary change
add more test &fix typo
|
@anorth , thanks for your comments, which are thoroughly considered and make things even simpler. Please review again. |
There was a problem hiding this comment.
Thanks, this basically looks good to me. My comments and suggestions now are relatively minor.
I'd like to defer to @ZenGround0 for final approval though, and discussion about when and where to merge.
fix withdraw unit test
* add method GetBeneficiary * fix package * rename * add test for getbeneficiary * export method
|
Landed in builtin actors, repo is deprecated |
This is an implementation for FIP-0029 PR #1571 to provide Beneficiary address support. In this implementation, version and upgrading is not considered, that is, directly put the code change into the current version. The back-compliance could be done once the next version content is determined.