This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
BatchBalancer fee charged on precommit aggregate #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1497 +/- ##
======================================
Coverage 71.5% 71.5%
======================================
Files 72 72
Lines 8612 8620 +8
======================================
+ Hits 6159 6167 +8
Misses 1563 1563
Partials 890 890 |
e586232 to
88ee459
Compare
0a70226 to
26fc40a
Compare
arajasek
reviewed
Oct 1, 2021
actors/builtin/miner/monies.go
Outdated
| return AggregateNetworkFee(aggregateSize, EstimatedSinglePreCommitGasUsage, baseFee) | ||
| } | ||
|
|
||
| func AggregateNetworkFee(aggregateSize int, gasUsage big.Int, baseFee abi.TokenAmount) abi.TokenAmount { |
There was a problem hiding this comment.
Can we not export this? I don't think it's needed, and it's only too easy for something (Lotus) to misuse this since it shares a name with the v5 method
arajasek
reviewed
Oct 1, 2021
actors/builtin/miner/monies.go
Outdated
| @@ -211,15 +211,25 @@ func LockedRewardFromReward(reward abi.TokenAmount) (abi.TokenAmount, *VestSpec) | |||
| } | |||
|
|
|||
| var EstimatedSingleProofGasUsage = big.NewInt(65733297) // PARAM_SPEC | |||
| var BatchDiscount = builtin.BigFrac{ // PARAM_SPEC | |||
| var EstimatedSingleProveCommitGasUsage = big.NewInt(49299973) | |||
There was a problem hiding this comment.
- You should be able to nuke EstimatedSingleProofGasUsage above^
- Out of curiosity, where do these numbers come from?
There was a problem hiding this comment.
They are rough estimates of the mean gas used per single PreCommit and ProveCommit. Empirically measured from tests and validated with small samples of on chain gas values. Wouldn't be surprised if they need tweaking down the line.
7c7f2ad to
0ed36e0
Compare
arajasek
approved these changes
Oct 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP #1492