Skip to content
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.

Remove handling of network versions < 11 from actors v5. #1416

Merged
merged 2 commits into from
May 18, 2021

Conversation

anorth
Copy link
Member

@anorth anorth commented May 16, 2021

Closes #1414.

@anorth anorth requested a review from ZenGround0 May 16, 2021 22:42
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2021

Codecov Report

Merging #1416 (f5b9070) into master (cef5d7e) will decrease coverage by 0.0%.
The diff coverage is 66.6%.

@@           Coverage Diff            @@
##           master   #1416     +/-   ##
========================================
- Coverage    69.9%   69.9%   -0.1%     
========================================
  Files          72      72             
  Lines        7786    7773     -13     
========================================
- Hits         5449    5438     -11     
+ Misses       1447    1444      -3     
- Partials      890     891      +1     

Copy link
Contributor

@ZenGround0 ZenGround0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small suggestions, LGTM

actors/builtin/miner/miner_actor.go Outdated Show resolved Hide resolved
@@ -4659,13 +4625,6 @@ func (h *actorHarness) preCommitSector(rt *mock.Runtime, params *miner.PreCommit
rt.ExpectSend(builtin.StoragePowerActorAddr, builtin.MethodsPower.EnrollCronEvent, cronParams, big.Zero(), nil, exitcode.Ok)
}

if rt.NetworkVersion() < network.Version7 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

actors/builtin/sector.go Outdated Show resolved Hide resolved
@anorth anorth force-pushed the anorth/v5cleanup branch from e0ed06f to f5b9070 Compare May 18, 2021 05:33
@anorth anorth merged commit 5114581 into master May 18, 2021
@anorth anorth deleted the anorth/v5cleanup branch May 18, 2021 05:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove v4 network upgrades from v5 code
3 participants