This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
Update specs-storage, sector removing support #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c20d9ed to
07cf84c
Compare
This was referenced Jun 22, 2020
laser
reviewed
Jun 22, 2020
| func (l *LocalWorker) Remove(ctx context.Context, sector abi.SectorID) error { | ||
| var err error | ||
|
|
||
| if rerr := l.storage.Remove(ctx, sector, stores.FTSealed, true); rerr != nil { |
There was a problem hiding this comment.
If the FTSealed is deleted, but the FTCache call fails - is there any mechanism for later cleaning up the FTUnsealed? or retrying the FTCache call?
There was a problem hiding this comment.
Currently no, only manual user intervention
arajasek
approved these changes
Jun 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will be needed for CC upgrade support in the FSM. Also allows for removing sectors, and has interfaces which will be used by unsealed-copy fast retrieval