fix: remove clear_layer_data call #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Double check that Forest isn't using this API |
|
If I grep for |
|
Though I would only merge then whenever we plan to do a breaking release. |
e0ca485 to
a488668
Compare
|
I've again checked Forrest. They have a minimal use of |
The `clear_layer_data` call was accidentally introduced with the Synthetic PoRep. The call does under the hood exactly what `clear_cache` is doing. It was already removed from the FFI via [PR 436], so that we can remove it here as well. This reduces the API surface, which is generally a good idea. [PR 436]: filecoin-project/filecoin-ffi#436 BREAKING CHANGE: `clear_layer_data` was removed, use `clear_cache` instead.
a488668 to
165af31
Compare
cryptonemo
approved these changes
Jan 6, 2025
vmx
added a commit
to filecoin-project/rust-fil-proofs
that referenced
this pull request
Jan 8, 2025
`clear_layer_data()` isn't used within rust-fil-proofs. It was also removed from proofs-api with the merge of filecoin-project/rust-filecoin-proofs-api#95.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
clear_layer_datacall was accidentally introduced with the Synthetic PoRep. The call does under the hood exactly whatclear_cacheis doing. It was already removed from the FFI via PR 436, so that we can remove it here as well. This reduces the API surface, which is generally a good idea.BREAKING CHANGE:
clear_layer_datawas removed, useclear_cacheinstead.