-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow for window post proving on a partition basis #1526
Conversation
@cryptonemo any thoughts why only darwin would show the testfailure? |
CI flakiness is my guess. The error is that it's missing parameters. I suspect a re-run may resolve it(?) |
I am not sure, the same error happened on the original PR, but no other PRs |
Rerunning CI should do the trick: cryptocorrosion/cryptocorrosion#48 |
didn’t work |
It's a different error though. |
Very odd. And specifically because it's a window post test failing for code that's changed those parts, it's suspect. I'll see if I can find anything locally at some point. This is not the kind of code I'd normally quickly merge in any case, as everything touching PoSt needs careful review. |
6b9ceff
to
f666295
Compare
0564619
to
1f3e0e9
Compare
1f3e0e9
to
8df5e59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a first cut, this looks good. I was able to generate the parameters on darwin, so CI is good, but haven't been able to hook up the save/restore code, so it's done each time. It's not ideal, but if this can land in Proofs v10.1.0, it can be resolved after that.
Resolved -- the test parameters are now generated on darwin. |
Looks good to me, my only question is regarding the mixed use of |
8df5e59
to
b8529ce
Compare
style: rust fmt
f5ef92f
to
6be136a
Compare
This is based on #1497 and attempts to reduce the changes to a minimum needed.
TODOs