Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Skip TestGoRPCAuth until Raft is fixed #9889

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

geoff-vball
Copy link
Contributor

Related Issues

Proposed Changes

Skips the flaky test until the underlying issue can be fixed. #9888

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@geoff-vball geoff-vball requested a review from a team as a code owner December 15, 2022 22:59
@jennijuju
Copy link
Member

Add a TODO: issue number in code as well? So next time colo we can do a todo bash

@geoff-vball geoff-vball force-pushed the gstuart/skip-raft-test branch from 7b092ab to dbb52ec Compare December 15, 2022 23:58
@geoff-vball geoff-vball merged commit 425d8a7 into master Dec 16, 2022
@geoff-vball geoff-vball deleted the gstuart/skip-raft-test branch December 16, 2022 00:17
@jennijuju jennijuju added this to the Network v18 milestone Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants