Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support creation and signing of Eth keys #9886

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

arajasek
Copy link
Contributor

Related Issues

Not having this functionality was making testing EthAccount abstraction difficult.

Proposed Changes

Support creating Eth keys, and generating signatures with them. Assumes all Delegated keytypes are Ethereum Account senders.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner December 15, 2022 21:43
Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM.

@arajasek arajasek force-pushed the asr/delegated-wallet branch from 6a6a65a to f8f07db Compare December 15, 2022 21:47
@arajasek arajasek merged commit d574eda into feat/nv18-fevm Dec 15, 2022
@arajasek arajasek deleted the asr/delegated-wallet branch December 15, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants