Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_ci_: Rely on local env varibale instead of context #9740

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

ianconsolata
Copy link
Contributor

@ianconsolata ianconsolata commented Nov 28, 2022

We have this env varible set in the project settings as well as the CircleCI context. Due to what seems like a bug on CircleCI's eng, the using the context causes our release flow to halt when some member of the team initiate releases, but not others. So for now, it's safest to rely on the project settings, which definitely won't cause this issue.

Specifically, if we don't merge this if @shrenujbansal creates the release tag again it will likely not work, but if that happens any other member of the filecoin-project or should be able to rebuild and have it work.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

We have this env varible set in the project settings as well as the
CircleCI context. Due to what seems like a bug on CircleCI's eng, the
using the context causes our release flow to halt when some member of
the team initiate releases, but not others. So for now, it's safest to
rely on the project settings, which definitely won't cause this issue.
@magik6k magik6k merged commit 1053310 into master Nov 29, 2022
@magik6k magik6k deleted the id/remove-circleci-context branch November 29, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants