Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baackport: ci: Fix issues with new goreleaser flow #9685

Merged
merged 5 commits into from
Nov 18, 2022

Conversation

geoff-vball
Copy link
Contributor

Related Issues

Backports #9684

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Goreleaser checks to make sure we don't have a dirty git state when
releasing, which means the kubo download we use to set up IPFS should be
removed before release.
Without this name, it assumes all binaries share the name of the project
(i.e. lotus), which causes them all to get renamed and collide when
generating the archive.
This will give us much more detailed information in the release job, so
we can more easily debug issues when they occur.
@geoff-vball geoff-vball requested a review from a team as a code owner November 18, 2022 17:03
@geoff-vball geoff-vball changed the base branch from master to release/v1.19.0 November 18, 2022 17:03
@shrenujbansal shrenujbansal merged commit 93c2e02 into release/v1.19.0 Nov 18, 2022
@shrenujbansal shrenujbansal deleted the gstuart/backport-goreleaser branch November 18, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants