Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: storage: Force exit GenerateSingleVanillaProof on cancelled context #9613

Merged
merged 3 commits into from
Nov 15, 2022

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Nov 9, 2022

Related Issues

Proposed Changes

  • Add some more logs to wdpost cycle logic
  • Respect context in local GenerateSingleVanillaProof
    • before it could block forever if underlying storage reads blocked, e.g. with disconnected NFS, which would lead to the entire PoSt failing
    • Now we'll return context error, which should result in only the slow-to-read sectors being skipped; There will also be a big, detailed log message printed.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k requested a review from a team as a code owner November 9, 2022 13:20
Co-authored-by: Piotr Bochenek <pbochenek@worldremit.com>
@magik6k magik6k merged commit 0e07fa9 into master Nov 15, 2022
@magik6k magik6k deleted the feat/wdpost-robustness branch November 15, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants