Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tvx: make it work with the FVM #9604

Merged
merged 3 commits into from
Nov 8, 2022
Merged

fix: tvx: make it work with the FVM #9604

merged 3 commits into from
Nov 8, 2022

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Nov 7, 2022 •
edited
Loading

Related Issues

#944

Proposed Changes

  • fixup VM creation to use FVM if appropriate for the network
  • implement View() for the tvx's Stores, which is needed by the FVM

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Stebalien and others added 2 commits November 7, 2022 16:09
@Stebalien @arajasek
fix: make test vector extraction work with the FVM
8df5b81 
This also ignores the VM "Flush" option and instead, flushes
unconditionally (in the FVM):

1. In the FVM, we don't read blocks on flush (ever).
2. All _uses_ of TVX use a "proxy" blockstore that buffers writes, so
nothing should actually get flushed to lotus.
@arajasek
tvx: stores: implement View()
ed83595
@arajasek arajasek requested a review from a team as a code owner November 7, 2022 21:41
@arajasek arajasek merged commit 9c5f385 into master Nov 8, 2022
@arajasek arajasek deleted the steb/fix-tvx-fvm branch November 8, 2022 14:28
@Fatman13 Fatman13 mentioned this pull request Nov 14, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulk raulk raulk approved these changes

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arajasek @Stebalien @raulk