Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NV18 Staging Branch #9599

Merged
merged 28 commits into from
Nov 29, 2022
Merged

NV18 Staging Branch #9599

merged 28 commits into from
Nov 29, 2022

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Nov 7, 2022 •
edited
Loading

This is the actual branch to deliver M2.1 as NV18 to the network.
It is intended to integrate all M2.1 changes for merge to master as soon as possible.

Workplan:

  • actors version 10 scaffolding
  • m2 bundle for version 10
  • state tree version 5
  • network version 18 migration and upgrade scaffolding -- can happen in follow up pr.
  • GREEN CI
  • Merge AFTER release/v1.19.0 is cut (Tuesday the 15th).

@vyzo vyzo requested a review from arajasek November 7, 2022 15:20
This was referenced Nov 8, 2022
Closed
Closed
@Stebalien
Copy link
Member

FYI, we'll need #9515 and we'll need to address the remaining TODOs (see @arajasek's comments).

@vyzo
Copy link
Contributor Author

vyzo commented Nov 8, 2022

Did some squashing, it is now ready in terms of support code to define state tree v5 and make thoz CI indicators green.

arajasek
arajasek reviewed Nov 16, 2022
View reviewed changes
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks good, I think we can land this in master relatively soon. I'm not a huge fan of the way we're versioning Actors, but I don't see any problems with it.

@vyzo
Copy link
Contributor Author

vyzo commented Nov 23, 2022

CI is having a fit.

@arajasek arajasek mentioned this pull request Nov 23, 2022
Closed
@vyzo vyzo marked this pull request as ready for review November 28, 2022 16:13
@vyzo vyzo requested a review from a team as a code owner November 28, 2022 16:13
@arajasek arajasek merged commit 275d9c1 into master Nov 29, 2022
@arajasek arajasek deleted the feat/nv18 branch November 29, 2022 16:22
@arajasek arajasek mentioned this pull request Nov 29, 2022
Closed
@simlecode simlecode mentioned this pull request Dec 12, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arajasek arajasek arajasek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyzo @Stebalien @arajasek