Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Drop rarely used binaries from build-devnets #9513

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

arajasek
Copy link
Contributor

Related Issues

Many people have complained that building devnets is slow.

Proposed Changes

Drop the external wallet, the gateway, stats, and fountain (faucet) from always being built when building devnets.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner October 18, 2022 20:36
@jennijuju jennijuju merged commit 5071a59 into master Oct 24, 2022
@jennijuju jennijuju deleted the asr/drop-fountain branch October 24, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants